stdlib: Accept keyword arguments in Net::HTTP.start
#2225
Merged
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original definition, keyword arguments could not be specified
without specifying all positional arguments.
Specifically, the following call results in an error with
`Ruby::ArgumentTypeMismatch`.
```rb
Net::HTTP.start('www.ruby-lang.org', 443, use_ssl: true)
```
This is because opt is treated as a hash positional argument.
This problem is solved by treating opt as a variable-length keyword argument.
ref. https://docs.ruby-lang.org/ja/latest/method/Net=3a=3aHTTP/s/start.html
soutaro
force-pushed
the
net-http-start
branch
from
5b3a79c to
1ce65bd
Compare
|
My commit adds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original definition, keyword arguments could not be specified without specifying all positional arguments.
Specifically, the following call results in an error with
Ruby::ArgumentTypeMismatch.This is because opt is treated as a hash positional argument.
This problem is solved by treating opt as a variable-length keyword argument.
ref. https://docs.ruby-lang.org/ja/latest/method/Net=3a=3aHTTP/s/start.html